Skip to content

Fixed the S/R version of nth_element with unit test added#6720

Open
sususu5 wants to merge 4 commits into
TheHPXProject:masterfrom
sususu5:fix-sr-nth_element
Open

Fixed the S/R version of nth_element with unit test added#6720
sususu5 wants to merge 4 commits into
TheHPXProject:masterfrom
sususu5:fix-sr-nth_element

Conversation

@sususu5
Copy link
Copy Markdown
Contributor

@sususu5 sususu5 commented Jun 13, 2025

Fixes #

Proposed Changes

  • Add scheduler-specific implementation for the parallel version of nth_element algorithm
  • Unit test from last year's GSoC project is added and passes
  • A line testing forward iterator on nth_element is removed from the test case because it does not conform to the C++ standard

Any background context you want to provide?

URL of the removed line in unit test
https://github.com/STEllAR-GROUP/hpx/blob/1dcd2571f809830809a7f9d4ecdce7f2b555ca2e/libs/core/algorithms/tests/unit/algorithms/nth_element_sender.cpp#L90

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

@sususu5 sususu5 requested a review from hkaiser as a code owner June 13, 2025 04:51
@StellarBot
Copy link
Copy Markdown
Collaborator

StellarBot commented Jun 13, 2025

Can one of the admins verify this patch?

@sususu5 sususu5 force-pushed the fix-sr-nth_element branch from c13ac23 to 330b2ea Compare June 18, 2025 04:36
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 17, 2026 •
edited
Loading

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

sususu5 and others added 2 commits May 17, 2026 13:45
@sususu5 @hkaiser
Fixed the S/R version of nth_element with unit test added
fdccb28 
Signed-off-by: David Hua <z5529749@ad.unsw.edu.au>
@hkaiser
Changed namespace
779069b 
- flyby: ading non-projected overloads for min_element, max_element, minmax_element

Signed-off-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Copilot AI review requested due to automatic review settings May 17, 2026 19:32
@hkaiser hkaiser force-pushed the fix-sr-nth_element branch from 8d80ae8 to 779069b Compare May 17, 2026 19:32
Copilot AI reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

sususu5 and others added 2 commits May 17, 2026 16:17
@sususu5 @hkaiser
File ends with a newline
07fff59 
Signed-off-by: David Hua <z5529749@ad.unsw.edu.au>
@hkaiser
Fixing range-based nth_element
0d3021f 
Signed-off-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

category: algorithms category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals type: compatibility issue type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sususu5 @StellarBot @hkaiser